From 1624c57867e60407b85571fd6b8680e977012d75 Mon Sep 17 00:00:00 2001
From: root <root@qq.com>
Date: Fri, 17 Jul 2026 09:21:50 +0800
Subject: [PATCH] fix: CoreAPI lifecycle - don't FreeCoreAPI until Stop

- Move FreeCoreAPI from defer in Start() to Stop()
- Call handle.Stop() before freeing resources
- This prevents SIGSEGV from plugins accessing freed CoreAPI memory
- Plugin's Go bridge code is safe (no C memory bugs)
---
 internal/plugin/dynamic.go | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/internal/plugin/dynamic.go b/internal/plugin/dynamic.go
index 5a2a943..a707474 100644
--- a/internal/plugin/dynamic.go
+++ b/internal/plugin/dynamic.go
@@ -60,13 +60,10 @@ type cabiPlugin struct {
 
 func (p *cabiPlugin) Name() string { return p.name }
 func (p *cabiPlugin) Start(s *sdk.PluginSDK) error {
-	// Create CoreAPI backed by the real PluginSDK and pass to plugin
 	corePtr := p.handle.CreateCoreAPI(s)
 	if corePtr == nil {
 		return fmt.Errorf("cabi: failed to create CoreAPI for %s", p.name)
 	}
-	defer p.handle.FreeCoreAPI()
-
 	if err := p.handle.Start(corePtr); err != nil {
 		return fmt.Errorf("cabi: start %s: %w", p.name, err)
 	}
@@ -74,6 +71,8 @@ func (p *cabiPlugin) Start(s *sdk.PluginSDK) error {
 }
 
 func (p *cabiPlugin) Stop() error {
+	_ = p.handle.Stop()
+	p.handle.FreeCoreAPI()
 	p.handle.Close()
 	return nil
 }