jianf/HomeAgent
1
0
Fork 0
mirror of https://gitcode.com/JianFeeeee/HomeAgent.git synced 2026-10-03 15:53:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: CoreAPI lifecycle - don't FreeCoreAPI until Stop

Browse Source 
- Move FreeCoreAPI from defer in Start() to Stop()
- Call handle.Stop() before freeing resources
- This prevents SIGSEGV from plugins accessing freed CoreAPI memory
- Plugin's Go bridge code is safe (no C memory bugs)
This commit is contained in:
root
2026-07-17 09:21:50 +08:00
parent 2ad46eee99
commit aeaa46b87d
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
internal/plugin/dynamic.go
View File

@ -60,13 +60,10 @@ type cabiPlugin struct {
func (p *cabiPlugin) Name() string { return p.name } func (p *cabiPlugin) Name() string { return p.name }
func (p *cabiPlugin) Start(s *sdk.PluginSDK) error { func (p *cabiPlugin) Start(s *sdk.PluginSDK) error {
// Create CoreAPI backed by the real PluginSDK and pass to plugin
corePtr := p.handle.CreateCoreAPI(s) corePtr := p.handle.CreateCoreAPI(s)
if corePtr == nil { if corePtr == nil {
return fmt.Errorf("cabi: failed to create CoreAPI for %s", p.name) return fmt.Errorf("cabi: failed to create CoreAPI for %s", p.name)
} }
defer p.handle.FreeCoreAPI()
if err := p.handle.Start(corePtr); err != nil { if err := p.handle.Start(corePtr); err != nil {
return fmt.Errorf("cabi: start %s: %w", p.name, err) return fmt.Errorf("cabi: start %s: %w", p.name, err)
} }
@ -74,6 +71,8 @@ func (p *cabiPlugin) Start(s *sdk.PluginSDK) error {
} }
func (p *cabiPlugin) Stop() error { func (p *cabiPlugin) Stop() error {
_ = p.handle.Stop()
p.handle.FreeCoreAPI()
p.handle.Close() p.handle.Close()
return nil return nil
} }