From b73ff3786a33ae8667733b54b2996f88a67a2f94 Mon Sep 17 00:00:00 2001
From: JianFeeeee <JianFeeeee@users.noreply.gitcode.com>
Date: Sat, 14 Nov 2026 10:38:37 +0800
Subject: [PATCH] =?UTF-8?q?test(security):=20=E8=A1=A5=20Gate=20=E6=98=8E?=
 =?UTF-8?q?=E6=96=87=E6=8B=A6=E6=88=AA/=E5=9B=9E=E5=A1=AB=E4=B8=8E=20Store?=
 =?UTF-8?q?=20=E8=B7=A8=E9=87=8D=E5=90=AF=E6=8C=81=E4=B9=85=E5=8C=96?=
 =?UTF-8?q?=E5=A5=91=E7=BA=A6?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

    Codec 原有 7 条保留。新增模块职责层判据：

    TestGateReplacesSecretOutboundAndBackfillsForExecution
      出向文本里出现真实凭据 → 被替换成 @{alias}，明文不再出现
      执行前 FillForExecution 把别名换回真实凭据
    TestGateScrubsSecretInbound
      入向泄漏的凭据被清洗，订阅侧看不到明文
    TestGateDisabledPassesTextThrough
      关闭状态原样透传、拦截计数 0
    TestStoreAliasRoundTripSurvivesReopen
      Submit 拿别名 → 重新打开同一存储 → Fill 回填出原文

    变异验证：
      去掉回填分支                 → 别名不再换回真实凭据（先前的失败）
      出向不产出别名               → outbound secret was not intercepted

    过程中修正了两处我自己写错的期望（回填目标必须先取别名、
    引用格式是 @{alias}），不是放宽实现。
---
 internal/security/test/codec_contract_test.go | 108 ++++++++++++++++++
 1 file changed, 108 insertions(+)

diff --git a/internal/security/test/codec_contract_test.go b/internal/security/test/codec_contract_test.go
index 8046e762..c1a335ff 100644
--- a/internal/security/test/codec_contract_test.go
+++ b/internal/security/test/codec_contract_test.go
@@ -4,6 +4,8 @@ package test
 // 不读源码、不碰 Codec/Store 内部字段、不用任何 ForTest 钩子。
 
 import (
+	"path/filepath"
+	"strings"
 	"testing"
 
 	"github.com/JianFeeeee/HologramAgent/internal/security"
@@ -138,3 +140,109 @@ func TestCodecOpenRejectsCorruptedCiphertext(t *testing.T) {
 		}
 	}
 }
+
+// ---- Gate 的模块职责：明文凭据在出向被换成别名，执行前再回填原值 ----
+
+func newGateStore(t *testing.T) *security.Store {
+	t.Helper()
+	st := security.New(security.Options{
+		Path:    filepath.Join(t.TempDir(), "vars.json"),
+		KeyFn:   func() ([]byte, error) { return fixedKey(11), nil },
+		Enabled: true,
+	})
+	if err := st.Load(); err != nil {
+		t.Fatalf("Load: %v", err)
+	}
+	return st
+}
+
+const contractSecret = "sk-proj-abcdefghijklmnopqrstuvwxyz0123456789"
+
+func TestGateReplacesSecretOutboundAndBackfillsForExecution(t *testing.T) {
+	store := newGateStore(t)
+	gate := security.NewGate(store)
+
+	out, n := gate.PrepareOutbound(security.Inspection{Stage: "to_llm"}, "key="+contractSecret)
+	if n == 0 {
+		t.Fatal("outbound secret was not intercepted")
+	}
+	if strings.Contains(out, contractSecret) {
+		t.Fatalf("outbound text still carries plaintext: %q", out)
+	}
+
+	// 出向文本里给出的是别名；执行前必须换回真实凭据。
+	alias := extractAlias(out)
+	if alias == "" {
+		t.Fatalf("alias not found in outbound text: %q", out)
+	}
+	back, filled := gate.FillForExecution(security.Inspection{Stage: "to_plugin"}, "key=@{"+alias+"}")
+	if filled != 1 {
+		t.Fatalf("backfill reported %d places", filled)
+	}
+	if back != "key="+contractSecret {
+		t.Fatalf("backfilled text = %q", back)
+	}
+}
+
+func TestGateScrubsSecretInbound(t *testing.T) {
+	gate := security.NewGate(newGateStore(t))
+	out, n := gate.ScrubInbound(security.Inspection{Stage: "tool_result"}, "leaked "+contractSecret)
+	if n == 0 || strings.Contains(out, contractSecret) {
+		t.Fatalf("inbound scrub failed: n=%d out=%q", n, out)
+	}
+}
+
+func TestGateDisabledPassesTextThrough(t *testing.T) {
+	st := security.New(security.Options{Enabled: false,
+		KeyFn: func() ([]byte, error) { return fixedKey(11), nil }})
+	gate := security.NewGate(st)
+	in := "key=" + contractSecret
+	if out, n := gate.PrepareOutbound(security.Inspection{}, in); out != in || n != 0 {
+		t.Fatalf("disabled gate modified text: %q n=%d", out, n)
+	}
+	if !gate.Enabled() == true {
+		t.Fatal("unexpected Enabled() result for disabled store")
+	}
+}
+
+func TestStoreAliasRoundTripSurvivesReopen(t *testing.T) {
+	dir := t.TempDir()
+	path := filepath.Join(dir, "vars.json")
+	first := security.New(security.Options{Path: path,
+		KeyFn: func() ([]byte, error) { return fixedKey(11), nil }, Enabled: true})
+	if err := first.Load(); err != nil {
+		t.Fatal(err)
+	}
+	alias, err := first.Submit(contractSecret, "contract")
+	if err != nil {
+		t.Fatalf("Submit: %v", err)
+	}
+	if alias == "" || alias == contractSecret {
+		t.Fatalf("alias = %q", alias)
+	}
+
+	second := security.New(security.Options{Path: path,
+		KeyFn: func() ([]byte, error) { return fixedKey(11), nil }, Enabled: true})
+	if err := second.Load(); err != nil {
+		t.Fatal(err)
+	}
+	back, n, _ := second.Fill("@{" + alias + "}")
+	if n != 1 || !strings.Contains(back, contractSecret) {
+		t.Fatalf("fill after reopen = %q (n=%d)", back, n)
+	}
+}
+
+// extractAlias 从安全模块产物里取出别名（公开契约：@\{alias\}）。
+func extractAlias(text string) string {
+	const marker = "@{"
+	i := strings.Index(text, marker)
+	if i < 0 {
+		return ""
+	}
+	rest := text[i+len(marker):]
+	j := strings.Index(rest, "}")
+	if j < 0 {
+		return ""
+	}
+	return rest[:j]
+}