P1 - forward inherits mode:
- doForward: when creating a new target session, use InheritedMode from
the source session (plan parent → plan child, cannot escalate)
- enforcement snapshot set from receiving agent
P1 - calendar_events gets permission_mode column:
- Added to 3 migration sites (sqlite init, pg init, incremental alter)
- CalendarEvent model gains PermissionMode field
- CreateCalendarEvent / UpdateCalendarEvent normalize + persist the field
- resolveCalendarSession: on new session → write event's mode;
on reuse → ModeAtMost(cur, eventMode), prevents escalation
(plan Agent's reminder fires into a workspace session = bypass)
- SendCalendarMail now takes permMode and threads it through
- fireEvent passes event.PermissionMode to all delivery paths
P1 - AdoptPlatformSession explicitly writes default mode:
- Writes DefaultPermissionMode + enforcement on adopt, instead of
relying on DB column default (avoids silent drift on schema changes)
P2 - PUT /sessions/{id}/permission endpoint:
- New handler UpdateSessionPermission (auth required, access check)
- Registers PUT route alongside existing budget/alias endpoints
- Broadcasts session_update on change
- Does NOT refresh enforcement (design: snapshot at creation)
P3 - Tests (24 new cases):
- permission_mode_test.go: InheritedMode (6 cases), SetSessionPermissionMode
roundtrip, dirty value fail-closed, NormalizePermissionMode, calendar event
roundtrip/dirty/update, adopt writes default mode, plan escalation guard,
3-level inheritance chain
- defaultsession_test.go: budget regression, permission mode regression
(pins created=false → no reset on reuse)
Deploys with: bash deploy/redeploy-gateway.sh --skip-tests
Schema migration: auto via addMissingColumns (new column default 'workspace')
398 lines
13 KiB
Go
398 lines
13 KiB
Go
package handler
|
||
|
||
import (
|
||
"net/http"
|
||
"strings"
|
||
|
||
"github.com/agentmail/gateway/internal/middleware"
|
||
"github.com/agentmail/gateway/internal/models"
|
||
"github.com/agentmail/gateway/internal/repo"
|
||
"github.com/agentmail/gateway/internal/sse"
|
||
"github.com/google/uuid"
|
||
)
|
||
|
||
// ---------- Session(均需登录,且做会话级鉴权) ----------
|
||
|
||
// requireSessionAccess 解析路径中的会话 ID 并校验当前用户有权访问
|
||
func requireSessionAccess(w http.ResponseWriter, r *http.Request) (uuid.UUID, bool) {
|
||
user := middleware.GetUser(r)
|
||
if user == nil {
|
||
Error(w, http.StatusUnauthorized, "not authenticated")
|
||
return uuid.Nil, false
|
||
}
|
||
sessionID, ok := pathUUID(w, r, "id")
|
||
if !ok {
|
||
return uuid.Nil, false
|
||
}
|
||
allowed, err := repo.UserCanAccessSession(r.Context(), user, sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to check permission")
|
||
return uuid.Nil, false
|
||
}
|
||
if !allowed {
|
||
Error(w, http.StatusForbidden, "无权访问该会话")
|
||
return uuid.Nil, false
|
||
}
|
||
return sessionID, true
|
||
}
|
||
|
||
// GET /api/v1/sessions/{id}
|
||
func GetSession(w http.ResponseWriter, r *http.Request) {
|
||
sessionID, ok := requireSessionAccess(w, r)
|
||
if !ok {
|
||
return
|
||
}
|
||
|
||
session, err := repo.GetSessionByID(r.Context(), sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusNotFound, "Session not found")
|
||
return
|
||
}
|
||
mails, err := repo.GetSessionMails(r.Context(), sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to get session mails")
|
||
return
|
||
}
|
||
// 会话线程要展示附件,逐封填充。
|
||
//
|
||
// 这里漏掉过:前端的会话视图走的是本端点(GET /sessions/{id}),
|
||
// 而不是下面那个 /sessions/{id}/mails —— 后者填了附件但没人调用,
|
||
// 于是 Agent 回信里的附件在 UI 上完全不存在。
|
||
ptrs := make([]*models.Mail, len(mails))
|
||
for i := range mails {
|
||
ptrs[i] = &mails[i]
|
||
}
|
||
fillAttachments(r, ptrs...)
|
||
|
||
JSON(w, http.StatusOK, map[string]interface{}{
|
||
"session": session,
|
||
"mails": emptySlice(mails),
|
||
})
|
||
}
|
||
|
||
// GET /api/v1/sessions/{id}/mails
|
||
func GetSessionMails(w http.ResponseWriter, r *http.Request) {
|
||
sessionID, ok := requireSessionAccess(w, r)
|
||
if !ok {
|
||
return
|
||
}
|
||
mails, err := repo.GetSessionMails(r.Context(), sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to get mails")
|
||
return
|
||
}
|
||
// 会话线程要展示附件,逐封填充
|
||
ptrs := make([]*models.Mail, len(mails))
|
||
for i := range mails {
|
||
ptrs[i] = &mails[i]
|
||
}
|
||
fillAttachments(r, ptrs...)
|
||
JSON(w, http.StatusOK, map[string]interface{}{
|
||
"mails": emptySlice(mails),
|
||
})
|
||
}
|
||
|
||
type updateAliasRequest struct {
|
||
Alias string `json:"alias"`
|
||
}
|
||
|
||
// PUT /api/v1/sessions/{id}/alias
|
||
//
|
||
// 会话别名负责三维寻址(name@path.<alias>),因此必须全局唯一,
|
||
// 且不能叫 "new"(那是寻址保留字)。
|
||
func UpdateSessionAlias(w http.ResponseWriter, r *http.Request) {
|
||
sessionID, ok := requireSessionAccess(w, r)
|
||
if !ok {
|
||
return
|
||
}
|
||
|
||
var req updateAliasRequest
|
||
if !DecodeBody(w, r, &req) {
|
||
return
|
||
}
|
||
alias := strings.TrimSpace(req.Alias)
|
||
if alias == "" {
|
||
Error(w, http.StatusBadRequest, "Missing alias")
|
||
return
|
||
}
|
||
if err := validateSessionAlias(alias); err != nil {
|
||
writeErr(w, err, "Invalid alias")
|
||
return
|
||
}
|
||
|
||
// 被其他会话占用时报 409,而不是默默造出两个同名可寻址会话
|
||
if s, err := repo.FindSessionByAlias(r.Context(), alias); err == nil && s.ID != sessionID {
|
||
Error(w, http.StatusConflict, "会话别名 \""+alias+"\" 已被其他会话占用")
|
||
return
|
||
}
|
||
|
||
if err := repo.UpdateSessionAlias(r.Context(), sessionID, alias); err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to update alias")
|
||
return
|
||
}
|
||
JSON(w, http.StatusOK, map[string]string{
|
||
"status": "updated",
|
||
"alias": alias,
|
||
})
|
||
}
|
||
|
||
// syncSessionRequest 是 Agent 平台回传自己那侧的会话标识。
|
||
//
|
||
// 各 Agent 平台(opencode / Claude Code / DSH…)都会由模型为会话生成一个摘要标题,
|
||
// 并配一个短 slug。不在本侧另造一套命名:平台那边叫什么,本侧就叫什么。
|
||
type syncSessionRequest struct {
|
||
// Alias 是平台侧的短标识(如 opencode 的 slug "jolly-cactus"),写入本侧 session_alias 供寻址。
|
||
Alias string `json:"alias"`
|
||
// Title 是平台侧模型生成的摘要标题(如「修复登录态丢失」),写入本侧 subject 供展示。
|
||
Title string `json:"title"`
|
||
}
|
||
|
||
// POST /api/v1/sessions/{id}/sync
|
||
//
|
||
// Agent 侧端点:把平台生成的会话标题与 slug 同步到本侧。
|
||
// alias 撞名时自动追加 -2/-3 后缀(本侧别名负责寻址必须唯一,而平台 slug 不保证全局唯一),
|
||
// 因此本接口不会因撞名失败,响应里回传最终落库的别名。
|
||
func SyncSession(w http.ResponseWriter, r *http.Request) {
|
||
agentName := middleware.GetAgentName(r)
|
||
if agentName == "" {
|
||
Error(w, http.StatusUnauthorized, "Unauthorized")
|
||
return
|
||
}
|
||
sessionID, ok := pathUUID(w, r, "id")
|
||
if !ok {
|
||
return
|
||
}
|
||
|
||
// Agent 只能同步自己参与过的会话
|
||
allowed, err := repo.AgentCanAccessSession(r.Context(), agentName, sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to check permission")
|
||
return
|
||
}
|
||
if !allowed {
|
||
Error(w, http.StatusForbidden, "无权修改未参与的会话")
|
||
return
|
||
}
|
||
|
||
var req syncSessionRequest
|
||
if !DecodeBody(w, r, &req) {
|
||
return
|
||
}
|
||
|
||
resp := map[string]string{"status": "synced"}
|
||
|
||
if title := strings.TrimSpace(req.Title); title != "" {
|
||
if err := repo.SyncSessionTitle(r.Context(), sessionID, title); err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to sync title")
|
||
return
|
||
}
|
||
resp["title"] = title
|
||
}
|
||
|
||
if alias := strings.TrimSpace(req.Alias); alias != "" {
|
||
// 平台 slug 可能带非法字符,落库前按本侧寻址规则规范化
|
||
norm := normalizeAlias(alias)
|
||
if norm == "" {
|
||
Error(w, http.StatusBadRequest, "alias 规范化后为空,无法作为寻址别名")
|
||
return
|
||
}
|
||
final, err := repo.SyncSessionAlias(r.Context(), sessionID, norm)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to sync alias")
|
||
return
|
||
}
|
||
resp["alias"] = final
|
||
}
|
||
|
||
// 让参与方前端立即看到新标题/别名
|
||
sse.Default.Broadcast("session_update", map[string]interface{}{
|
||
"session_id": sessionID.String(),
|
||
"alias": resp["alias"],
|
||
"title": resp["title"],
|
||
})
|
||
|
||
JSON(w, http.StatusOK, resp)
|
||
}
|
||
|
||
// GET /api/v1/sessions/{id}/rename-proposal
|
||
//
|
||
// 返回该会话里最新一条尚未处理的改名提议(Agent 在正文里提的)。
|
||
// 「尚未处理」= 既不是当前别名(已接受),也不在驳回记录里。
|
||
// 无提议时返回 {"proposal": null},前端据此决定要不要显示提示条。
|
||
func GetRenameProposal(w http.ResponseWriter, r *http.Request) {
|
||
sessionID, ok := requireSessionAccess(w, r)
|
||
if !ok {
|
||
return
|
||
}
|
||
alias, reason, err := repo.PendingRenameProposal(r.Context(), sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to load proposal")
|
||
return
|
||
}
|
||
if alias == "" {
|
||
JSON(w, http.StatusOK, map[string]interface{}{"proposal": nil})
|
||
return
|
||
}
|
||
JSON(w, http.StatusOK, map[string]interface{}{
|
||
"proposal": map[string]string{"alias": alias, "reason": reason},
|
||
})
|
||
}
|
||
|
||
// POST /api/v1/sessions/{id}/rename-proposal/dismiss
|
||
//
|
||
// 用户驳回当前提议。记下被驳回的别名,好让提示条不再反复弹同一个建议 ——
|
||
// 否则每次打开会话都要重新点一次「忽略」。
|
||
//
|
||
// 接受提议走已有的 PUT /sessions/{id}/alias,不另开端点:
|
||
// 那条路径已经有唯一性校验与 409 处理,复制一遍只会多一个出错的地方。
|
||
func DismissRenameProposal(w http.ResponseWriter, r *http.Request) {
|
||
sessionID, ok := requireSessionAccess(w, r)
|
||
if !ok {
|
||
return
|
||
}
|
||
alias, _, err := repo.PendingRenameProposal(r.Context(), sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to load proposal")
|
||
return
|
||
}
|
||
if alias == "" {
|
||
// 已经没有待处理提议(可能是另一个标签页刚处理过),当作成功
|
||
JSON(w, http.StatusOK, map[string]string{"status": "no_pending"})
|
||
return
|
||
}
|
||
if err := repo.DismissRenameProposal(r.Context(), sessionID, alias); err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to dismiss proposal")
|
||
return
|
||
}
|
||
JSON(w, http.StatusOK, map[string]string{
|
||
"status": "dismissed",
|
||
"dismissed": alias,
|
||
})
|
||
}
|
||
|
||
type sessionBudgetRequest struct {
|
||
// MaxRounds 是本会话的往返预算上限(0 = 不限)。
|
||
MaxRounds *int `json:"max_rounds"`
|
||
// Reset 把已用次数归零(上限不变)。可与 MaxRounds 同时给:
|
||
// 「加到 20 并从头算」是一次很自然的操作,拆成两个请求只会让前端多一次往返。
|
||
Reset bool `json:"reset"`
|
||
}
|
||
|
||
type updatePermissionRequest struct {
|
||
// PermissionMode 三档 plan / workspace / full。
|
||
//
|
||
// 对话页里人可随时改,改了即时生效(不继承、不限「只能同档或更严」——
|
||
// 那是 Agent 主动派子任务时的约束;人改档是对一条已有会话的明示意愿,
|
||
// 可以从 plan 直接调到 full)。脏值 fail-closed 到默认档而不是 full。
|
||
PermissionMode string `json:"permission_mode"`
|
||
}
|
||
|
||
// PUT /api/v1/sessions/{id}/permission
|
||
//
|
||
// 对话页里随时调档位。与 budget 同位置编辑:两者都是任务的属性,
|
||
// 人看着往来内容才知道「这件事现在该收紧还是放开」。
|
||
//
|
||
// 人类可以任改三档(包括从 plan 提到 full —— 人是权限的源头);
|
||
// Agent 不经此端点(Agent 改档须走发信继承路径,不得自行提权)。
|
||
func UpdateSessionPermission(w http.ResponseWriter, r *http.Request) {
|
||
sessionID, ok := requireSessionAccess(w, r)
|
||
if !ok {
|
||
return
|
||
}
|
||
var req updatePermissionRequest
|
||
if !DecodeBody(w, r, &req) {
|
||
return
|
||
}
|
||
mode := models.NormalizePermissionMode(req.PermissionMode)
|
||
if mode == "" {
|
||
mode = models.DefaultPermissionMode
|
||
}
|
||
perm, err := repo.SetSessionPermissionMode(r.Context(), sessionID, mode)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to update permission mode")
|
||
return
|
||
}
|
||
|
||
// 强制力不在此刷新:它是「平台能力」的事实快照,在会话建立时定死
|
||
// (见 repo.SetSessionEnforcement 的注释)。人改档位不改变平台的能力,
|
||
// 插件升级才改变 —— 那要等新投递/新会话才会反映。
|
||
|
||
sse.Default.Broadcast("session_update", map[string]interface{}{
|
||
"session_id": sessionID.String(),
|
||
"permission_mode": perm.Mode,
|
||
"permission_enforcement": perm.Enforcement,
|
||
})
|
||
JSON(w, http.StatusOK, perm)
|
||
}
|
||
|
||
// GET /api/v1/sessions/{id}/budget
|
||
//
|
||
// 本会话的往返预算。与 Agent 全局配额是两层,都要过:
|
||
// 会话预算管「这件事值得多少个来回」,全局配额管「这个 Agent 总共能发多少」。
|
||
func GetSessionBudgetHandler(w http.ResponseWriter, r *http.Request) {
|
||
sessionID, ok := requireSessionAccess(w, r)
|
||
if !ok {
|
||
return
|
||
}
|
||
b, err := repo.GetSessionBudget(r.Context(), sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusNotFound, "Session not found")
|
||
return
|
||
}
|
||
JSON(w, http.StatusOK, b)
|
||
}
|
||
|
||
// PUT /api/v1/sessions/{id}/budget
|
||
//
|
||
// 在对话页里随时调本任务的预算 —— 这是配额最该被编辑的地方:
|
||
// 人看着往来内容才知道这件事还值不值得再来几个回合。
|
||
func UpdateSessionBudget(w http.ResponseWriter, r *http.Request) {
|
||
sessionID, ok := requireSessionAccess(w, r)
|
||
if !ok {
|
||
return
|
||
}
|
||
var req sessionBudgetRequest
|
||
if !DecodeBody(w, r, &req) {
|
||
return
|
||
}
|
||
if req.MaxRounds == nil && !req.Reset {
|
||
Error(w, http.StatusBadRequest, "需要给出 max_rounds 或 reset")
|
||
return
|
||
}
|
||
|
||
b, err := repo.GetSessionBudget(r.Context(), sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusNotFound, "Session not found")
|
||
return
|
||
}
|
||
if req.MaxRounds != nil {
|
||
if *req.MaxRounds < 0 {
|
||
Error(w, http.StatusBadRequest, "max_rounds 不能为负")
|
||
return
|
||
}
|
||
// 允许调到低于已用次数:那表示「就到这里为止」,是人的合法意图。
|
||
// 此时剩余为 0,Agent 下次发信即被拦。
|
||
b, err = repo.SetSessionBudget(r.Context(), sessionID, *req.MaxRounds)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to set budget")
|
||
return
|
||
}
|
||
}
|
||
if req.Reset {
|
||
b, err = repo.ResetSessionBudget(r.Context(), sessionID)
|
||
if err != nil {
|
||
Error(w, http.StatusInternalServerError, "Failed to reset budget")
|
||
return
|
||
}
|
||
}
|
||
|
||
// 让会话的其他参与方(含 Agent 侧界面)立刻看到新预算
|
||
sse.Default.Broadcast("session_update", map[string]interface{}{
|
||
"session_id": sessionID.String(),
|
||
"budget_max": b.Max,
|
||
"budget_used": b.Used,
|
||
"budget_remaining": b.Remaining,
|
||
})
|
||
JSON(w, http.StatusOK, b)
|
||
}
|